Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-kogito-docs-641: Remove Job Service All in one image from documentation #642

Merged
merged 2 commits into from
May 30, 2024

Conversation

wmedvede
Copy link
Contributor

@wmedvede wmedvede commented May 28, 2024

Closes #641

Description:

Please make sure that your PR meets the following requirements:

  • You have read the contributions doc
  • Pull Request title is properly formatted: Issue-XYZ Subject
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Issue-XYZ Subject
  • The nav.adoc file has a link to this guide in the proper category
  • The index.adoc file has a card to this guide in the proper category, with a meaningful description
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Copy link
Contributor

github-actions bot commented May 28, 2024

🎊 PR Preview ce2e35c has been successfully built and deployed. See the documentation preview: https://sonataflow-docs-preview-pr-642.surge.sh

@wmedvede wmedvede changed the title [Draft PR, don't mind] Draft PR Changes kie-kogito-docs-641: Remove Job Service All in one image from documentation May 28, 2024
@wmedvede wmedvede marked this pull request as ready for review May 28, 2024 17:07
@wmedvede wmedvede requested a review from nmirasch May 28, 2024 17:07
@wmedvede
Copy link
Contributor Author

This is not draft anymore, would you mind guys review?
@ricardozanini @domhanak @nmirasch @kaldesai

@wmedvede
Copy link
Contributor Author

Hi @kaldesai , this Job Service section is related to the conversation we had in Monday's meeting.
Where we chatted about that Job Service should now go into the product documentation similar to what you did or are doing for the data-index.

@domhanak domhanak requested review from gmunozfe and removed request for domhanak May 29, 2024 07:27
@domhanak
Copy link
Contributor

@gmunozfe please check, this is JS related

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just align the value with the example

@wmedvede
Copy link
Contributor Author

Just align the value with the example

added

Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good work @wmedvede !

@wmedvede wmedvede merged commit 8a44d6b into apache:main May 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Job Service All in one image from documentation
5 participants